-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: allow local multi build #710
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: Added TODOs
…o socket-authenticator-option
…uthentication by SSHRV
…er class to create the right message type
…er class to create the right message type
…esult of many a files uptaking the new name.
…-option # Conflicts: # packages/noports_core/lib/src/sshnp/impl/sshnp_openssh_local_impl.dart # packages/noports_core/lib/src/sshrvd/sshrvd_impl.dart
…o socket-authenticator-option
1. Changes to take args to accept authenticateClient and authenticateDevice args 2. Using the values of these args to make decisions 3. Changes to the way we sign the data
- new sshrv parameters --bind-local-port and --rvd-auth-string - uses new socket_connector method, serverToSocket - multiple other tweaks to get things to work
…d IV in sshrv. Next commit will have the AES key and IV creation, sharing, and passing in to the sshrv process via command line and parameters
- add checkForFinalDeliveryStatus and waitForFinalDeliveryStatus parameters everywhere we call `notify` - make callers use those parameters appropriately. Note that in no case was there a need for those parameters to be true, but it seems better to introduce the parameters and make callers explicitly aware of them, rather than the simpler change to just set them to false in every case.
…s the daemon supports. This is then used to downgrade where the daemon does not support the feature
…ted out two 'return' statements for now, in the runZonedGuarded onError handler
…g because of timeout waiting for sshrvd response
- in ping response, daemon says whether or not it accepts public keys from the client - added abbreviations in SshnpArg for the new flags - corrected some code comments and added to others
By default sshnp now immediately drops into a prompt for clients that don't support sshnp.canRunShell(). -x allows the ssh command to be output instead of executing ssh immediately.
refactor(BREAKING CHANGE): Rename sshrv to srv
feat(BREAKING CHANGE): add -x flag
Oops PR to wrong base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
ci: allow local multi build