Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow local multi build #710

Closed
wants to merge 88 commits into from
Closed

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Jan 22, 2024

- What I did

  • Enabled multibuild to work against the local noports_core and pubspec.lock dependencies
  • Should be more consistent builds since we can commit pubspec.lock without error
  • We can also do test builds without needing to release noports_core first

- How I did it

- How to verify it

- Description for the changelog
ci: allow local multi build

gkc and others added 30 commits November 23, 2023 12:19
docs: Added TODOs
…esult of many a files uptaking the new name.
…-option

# Conflicts:
#	packages/noports_core/lib/src/sshnp/impl/sshnp_openssh_local_impl.dart
#	packages/noports_core/lib/src/sshrvd/sshrvd_impl.dart
1. Changes to take args to accept authenticateClient and authenticateDevice args
2. Using the values of these args to make decisions
3. Changes to the way we sign the data
- new sshrv parameters --bind-local-port and --rvd-auth-string
- uses new socket_connector method, serverToSocket
- multiple other tweaks to get things to work
…d IV in sshrv. Next commit will have the AES key and IV creation, sharing, and passing in to the sshrv process via command line and parameters
- add checkForFinalDeliveryStatus and waitForFinalDeliveryStatus parameters everywhere we call `notify`
- make callers use those parameters appropriately.
Note that in no case was there a need for those parameters to be true, but it seems better to introduce the parameters and make callers explicitly aware of them, rather than the simpler change to just set them to false in every case.
…s the daemon supports. This is then used to downgrade where the daemon does not support the feature
…ted out two 'return' statements for now, in the runZonedGuarded onError handler
gkc and others added 26 commits January 18, 2024 12:36
…g because of timeout waiting for sshrvd response
- in ping response, daemon says whether or not it accepts public keys from the client
- added abbreviations in SshnpArg for the new flags
- corrected some code comments and added to others
By default sshnp now immediately drops into a prompt for clients that don't support sshnp.canRunShell(). -x allows the ssh command to be output instead of executing ssh immediately.
refactor(BREAKING CHANGE): Rename sshrv to srv
@XavierChanth XavierChanth requested review from gkc and cpswan January 22, 2024 14:26
@XavierChanth
Copy link
Member Author

Oops PR to wrong base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants